← Back to team overview

kicad-developers team mailing list archive

<config.h>, and the format checker

 

Hi,

we have a build failure on MSVC because ngspice.cpp no longer includes
<config.h>. This file should really be included first by any cpp file,
because it uses macros to work around compiler differences.

The format checker rightly suggests that, as it is a <> include from the
local project, it should go after the ** includes. Can we somehow
special-case this?

In the long run, we probably want to have a <stdafx.h> or similar file
per project, which lists all the external includes, and is precompiled
before the rest of the project, this would have the same constraint, but
as a hard requirement (i.e. we get compiler errors if the include isn't
the first non-comment in the file).

What would be required to adjust the format checker?

   Simon

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups