kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #43444
Re: Two patches to submit (eeschema)
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
jp charras <jp.charras@xxxxxxxxxx>
-
Date:
Mon, 10 Feb 2020 19:52:05 +0100
-
In-reply-to:
<CACp=VfZvet4yu-tDGytKABxOL3Jj+evkm5pXRRqGsao_6XEcjQ@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; rv:68.0) Gecko/20100101 Thunderbird/68.4.2
Le 10/02/2020 à 19:37, Ian McInerney a écrit :
> Sylwester,
>
> Would it be possible for you to submit these are two merge requests to the KiCad GitLab repository: https://gitlab.com/kicad/code/kicad/-/tree/master. We have started to use the merge requests to better track and review the patches that are submitted.
>
> Thanks,
> -Ian
>
> On Mon, Feb 10, 2020 at 5:27 PM Sylwester Kocjan <s.kocjan@xxxxx <mailto:s.kocjan@xxxxx>> wrote:
>
> Hi,
>
> I have two patches to submit:
>
> 1. Three new types of sources have been implemented in dialog_spice_model.
>
> 2. One minor bug is fixed (removing less than zero rows from grid)
> and one small improvement is added (ESC will close netlist window
> in simulation).
>
> I'd appreciate if you could take a look at it and comment.
>
> Best regards,
> Sylwester
Hi, Sylwester,
I have 2 remarks:
- patches need to be rebased to the latest master version.
They are clearly not up to date.
- I am not thrilled by quitting the simulator frame by Escape:
This is not a dialog.
This is a tool like the schematic editor or the symbol editor.
Thanks for you work.
--
Jean-Pierre CHARRAS
References