← Back to team overview

kicad-developers team mailing list archive

Re: Removal of some globals

 

On Sun, 2020-04-05 at 20:48 +0200, jp charras wrote:
> Le 05/04/2020 à 17:20, Jeff Young a écrit :
> > I had to remove some globals from Eeschema that were causing problems (default line width, text size, wire thickness, bus thickness etc.).
> > 
> > It was a large change (as these things always are), so let me know if you see anything odd.
> > 
> > Cheers,
> > Jeff.
> 
> Hi Jeff:
> a typo in function:
> int LIB_CIRCLE::GetPenSize() const
> is missing the return statement.
> 

This should not even compile.  On GCC there is "-Werror=return-type"
for that.  Any particular reason why not to use this diagnostic?

Cheers,
Oleg



References