← Back to team overview

kicad-developers team mailing list archive

Re: schematic.cpp includes sim/ngspice.h and consequently sharedspice.h

 

I thought about that but in what context does a simulation make sense
out side of a schematic or a netlist generated from a schematic?  I
saved the ngspice simulator settings in the project file because that is
the proper scope of the setting.  I really don't see a more logical
place to save the setting.   I suppose I could split out the simulator
settings code but it would be awkward at best.

On 3/18/21 6:42 PM, Jon Evans wrote:
> Wayne, I haven't checked this code carefully but I'd recommend building
> the settings always, and moving the #ifdef to a different level (i.e.
> make the settings not depend on ngspice)
> 
> That way if the same settings files are shared between a build with
> ngspice and a build without, they won't get thrown away.
> 
> On Thu, Mar 18, 2021 at 6:37 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     My bad.  I forgot the simulator was a build option so I will have to
>     #ifdef the offending settings code.
> 
>     - Wayne
> 
>     On 3/18/21 6:02 PM, Eeli Kaikkonen wrote:
>     > I have disabled ngspice in cmake settings but in a recent commit by
>     > Wayne #include <sim/ngspice.h>, which in turn includes
>     > ngspice/sharedspice.h, was added to schematic.cpp which makes
>     > compilation fail apparently because I don't have ngspice at all.
>     >
>     > Eeli Kaikkonen
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 


Follow ups

References