kicad-developers team mailing list archive

[Seth Hillbrand <seth@xxxxxxxxxxxxx>]

Looks like Holger just added this:

https://github.com/imr/ngspice/commit/ded0f79c01079eaa6f4cdbd49292897c73273e23

I'm not sure why.  I think Holger is on this list, so hopefully he can help
explain the reasoning.

-Seth

On Tue, May 4, 2021 at 2:04 PM Jon Evans <jon@xxxxxxxxxxxxx> wrote:

> What version of ngspice are you using?
>
> Sourceforge is down right now so I can't check the latest tree easily, but
> in my cached version, the ControlledExit function signature in
> sharedspice.h is using bool (not BOOL), and so is KiCad.
>
> Is there some version of ngspice where those function signatures are BOOL
> (aka int) not bool?
>
> -Jon
>
> On Tue, May 4, 2021 at 4:49 PM BERTRAND Joël <joel.bertrand@xxxxxxxxxxx>
> wrote:
>
>>         Hello,
>>
>>         I use KiCAD 5.99 as rolling release. For a few days, compilation
>> aborts
>> with :
>>
>> [ 32%] Building CXX object
>> eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o
>> /home/bertrand/git/kicad/eeschema/sim/ngspice.cpp: In member function
>> ‘void NGSPICE::init_dll()’:
>> /home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:486:47: error: invalid
>> conversion from ‘int (*)(int, bool, bool, int, void*)’ to ‘int (*)(int,
>> BOOL, BOOL, int, void*)’ {aka ‘int (*)(int, int, int, int, void*)’}
>> [-fpermissive]
>>   486 |     m_ngSpice_Init( &cbSendChar, &cbSendStat, &cbControlledExit,
>> NULL, NULL,
>>       |                                               ^~~~~~~~~~~~~~~~~
>>       |                                               |
>>       |                                               int (*)(int, bool,
>> bool, int, void*)
>> /home/bertrand/git/kicad/eeschema/sim/ngspice.cpp:487:21: error: invalid
>> conversion from ‘int (*)(bool, int, void*)’ to ‘int (*)(BOOL, int,
>> void*)’ {aka ‘int (*)(int, int, void*)’} [-fpermissive]
>>   487 |                     &cbBGThreadRunning, this );
>>       |                     ^~~~~~~~~~~~~~~~~~
>>       |                     |
>>       |                     int (*)(bool, int, void*)
>> make[2]: ***
>> [eeschema/CMakeFiles/eeschema_kiface_objects.dir/build.make:2846 :
>> eeschema/CMakeFiles/eeschema_kiface_objects.dir/sim/ngspice.cpp.o] Erreur
>> 1
>> make[1]: *** [CMakeFiles/Makefile2:3021 :
>> eeschema/CMakeFiles/eeschema_kiface_objects.dir/all] Erreur 2
>> make: *** [Makefile:182 : all] Erreur 2
>>
>>         I have built ngspice library from source (git).
>>
>>         To be sure that this issue is reproductible, I have rebuild
>> ngspice
>> library and kicad from scratch with the same error.
>>
>>         My workstation runs with Linux Debian/testing (up to date) with
>> gcc
>> 10.2.1. If I understand gcc error, compiler complains about mistake
>> between BOOL (that seems to be 'int') and bool, but I don't known C++
>> enough to fix it.
>>
>>         Best regards,
>>
>> --
>> KACHELHOFFER-BERTRAND Joël
>> http://www.systella.fr
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬
Long Beach, CA
www.kipro-pcb.com    info@xxxxxxxxxxxxx