← Back to team overview

kicad-developers team mailing list archive

Re: First Merge Request


Hi Mike-

Thank you for the contributions!  We're always glad to have new
contributors interested in improving KiCad.

In the merge request workflow, people will sometimes mark their merge
requests as "Draft" or "WIP" as you did for 883.  When you do this, we
generally won't look it over unless you ask for specific feedback.
Otherwise, we'll assume that it isn't ready for review and just leave it in
the queue.

In general, we prefer MRs address specific issues.  Typically, we will
discuss the problem in the issue report (sometimes you will get feedback
that the issue shouldn't be address).  In the MR, we typically only discuss
the code and how it is implemented.

We do not have any documentation at the moment on the KiWay system outside
of the doxygen comments.  Sending a KiWay is usually reserved for
communication between apps.  Inside the application, you would typically
call the routine directly or send a tool event, depending on the action you

Thanks for the contributions and we look forward to working with you!

One last aside: as you probably know, we are currently in a feature freeze
for version 6.  There are a number of outstanding issues that we are
working through but we are not adding new features at the moment.  If you'd
like to take a swing at fixing some of the remaining issues, you can find
them here:


On Tue, Jul 20, 2021 at 10:57 AM Mike Williams <mikebwilliams@xxxxxxxxx>

> Hello All,
> I've posted my first merge request to the KiCad gitlab. It seems to be
> within the guidelines now, sorry for spamming the previous requests. I was
> having some trouble with GitLab identifying whether or not the commits
> could be rebased onto master with fast forwarding only. It was almost
> certainly my mistake, I'm more used to patch submission using git
> format-patch than merge requests.
> https://gitlab.com/kicad/code/kicad/-/merge_requests/883
> My goal is to contribute by fixing a few small annoyances here and there.
> Is it preferred that I open an Issue for each fix that I can reference in
> my merge request, or to just send the merge request with the changes
> described?
> Also, is there any documentation outside of doxygen for the KiWay and
> Hotkey subsystems? For KiWay, I was unsure whether it was better to call
> functions directly or to use KiWay events when both would have the same
> functionality. For hotkeys, I was thinking about adding more hotkeys to the
> pin table editor.
> The codebase in general seems very clean. Thanks for a great product, I've
> shipped numerous designs with it.
> Mike
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
Long Beach, CA
www.kipro-pcb.com    info@xxxxxxxxxxxxx