← Back to team overview

kicad-doc-devs team mailing list archive

Re: Keyword "_T" for translations?

 

These should be _( "" ) not _T( "" ).  Looks like someone used the
incorrect translation macros.  The exception is the wxASSERT_MSG string.
 Debug macro strings should not be translated.  I don't think the
wxPyConvertSwigPtr() string should be translated either.

On 8/31/2016 3:14 PM, Carsten Schoenert wrote:
> 
> Am 31.08.2016 um 21:08 schrieb Carsten Schoenert:
> [...]
> 
> To be more precise
> 
>> $ git grep -n " _T( \""
> 
>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:143:    wxButton* btn_OK = new wxButton( this, wxID_OK, _T( "OK" ) );
>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:144:    wxButton* btn_Cancel = new wxButton( this, wxID_CANCEL, _T( "Cancel" ) );
>> common/dialog_about/aboutinfo.h:97:        copyrightText.Replace( _T( "(c)" ), utf8_copyrightSign );
>> common/dialog_about/aboutinfo.h:98:        copyrightText.Replace( _T( "(C)" ), utf8_copyrightSign );
>> pcbnew/dialogs/dialog_edit_module_for_BoardEditor.cpp:501:        wxMessageBox( msg, _T( "Edit 3D file name" ) );
>> pcbnew/dialogs/dialog_edit_module_for_Modedit.cpp:352:        wxMessageBox( msg, _T( "Edit 3D file name" ) );
>> scripting/python_scripting.cpp:290:        bool success = wxPyConvertSwigPtr( result, (void**) &window, _T( "wxWindow" ) );
>> scripting/python_scripting.cpp:293:        wxASSERT_MSG( success, _T( "Returned object was not a wxWindow!" ) );
> 


Follow ups

References