kicad-doc-devs team mailing list archive
-
kicad-doc-devs team
-
Mailing list archive
-
Message #00033
Re: [PATCH] Decrease the duplicated image data for HTML documentation
Hi Carsten
I have not forgot you! Sorry, I have not had too much time to review
this before now.
To comment a bit. I would like to not use use a way that needs
symlinks because they are not portable. I could possibly be an option
for systems that do support it, but I think we should try to avoid
it.
It seems systems like debian likes to split all languages up into
seperate packages. I don't know if they have a common package or what
they do for the common.
Please note that there is essentially three locations for images as it
it seems. Just looking at the html source for the french doc I see the
following example:
images/en/status_bar.png
images/fr/menu_bar.png
images/toolbar_schedit_standalone.png
These are relative to the /share/doc/kicad/help/$LANG path.
How would you handle that gracefully? If we can do it without symlinks
and duplicated data that would be number one choice.
I would like to not mix up the images root images and the en images
dir into one dir.
I have not tested your patch because I am not at my system, but
reading the comment you mention that it is only a partial solution. If
you could make a patch for a complete solution that would be best, I
think.
2016-09-24 14:00 GMT+02:00 Carsten Schoenert <c.schoenert@xxxxxxxxxxx>:
> Hello Nick,
>
> Am 24.09.2016 um 13:55 schrieb Nick Østergaard:
>> I looks like you were trying to attach an inline patch, but I can not
>> see it other than the header. Please try to make it as a new
>> attachment.
>
> I was using classical command git-send-email. Nevertheless, patch (re)
> appended.
>
>> This issue is related to https://github.com/KiCad/kicad-doc/issues/170
>
> O.k. Didn't noticed that.
>
> --
> Regards
> Carsten Schoenert
Follow ups
References