kicad-lib-committers team mailing list archive

[Carl Poirier <carl.poirier.2@xxxxxxxxx>]

Hi Jon,

This is awesome. Is there a way to paste the results.txt directly into a
comment in the pull request?

On Sat, Nov 7, 2015 at 11:01 PM, Jon Neal <reportingsjr@xxxxxxxxx> wrote:

> Drum roll...
>
> It is now (mostly) working on the kicad-library repo!
>
> Any new pull requests submitted will be checked, if you want to check an
> old pull request simply comment 'test this please' and it will be tested
> and updated.
>
> Caveats:
> * It isn't super obvious for contributors where to look for what the
> errors were.
> * If someone is updating a symbol that already has an issue (e.g. really
> common for text size to be incorrect) then the symbol will pass. So don't
> take the pass as a 100% pass until all of the current footprints pass the
> checklib.py script.
>
> I did a test check so everyone can see what it looks like:
> https://github.com/KiCad/kicad-library/pull/327
>
> Any questions or comments?
> Jon
>
> On Mon, Oct 19, 2015 at 9:26 PM, Jon Neal <reportingsjr@xxxxxxxxx> wrote:
>
>> Thanks for the heads up Carl. I'll talk to Miguel if the account
>> credentials aren't already in jenkins.
>>
>> So I got my setup to the point where it compares the output of
>> checklib.py from master and the pull request and if there is a difference
>> it marks the PR as failed.
>>
>> Example: https://github.com/reportingsjr/kicad-library/pull/3
>>
>> The output is pretty terrible for people who want to see the exact
>> issues. If the PR fails you can find the full output of checklib.py under
>> the jenkins console and you can ctrl-f for the diff marks (just >).
>>
>> You should be able to see this here:
>> http://208.102.106.210:8080/job/github%20pr%20test/24/console
>>
>>
>> I feel like this is at least useful enough to set up on the real jenkins
>> server and git repo so PRs can be marked as pass or fail. I would like to
>> get opinions from all of you first though!
>>
>> Thanks,
>> Jon
>>
>> On Tue, Oct 13, 2015 at 8:51 AM, Carl Poirier <carl.poirier.2@xxxxxxxxx>
>> wrote:
>>
>>> Hi Jon,
>>>
>>> That's insane. There is already the kicadjenkins account for that. I
>>> believe it's managed by Miguel.
>>> On Oct 13, 2015 2:51 AM, "Jon Neal" <reportingsjr@xxxxxxxxx> wrote:
>>>
>>>> So I almost have a jenkins setup that will watch for pull requests on
>>>> just kicad-library (small steps here!) and check the whole library with the
>>>> pull request changes included. It updates the status of the pull request
>>>> and everything.
>>>>
>>>> However.. the script currently runs through everything in the library
>>>> (kicad-library/library/*.lib) and fails if there are any issues. There are
>>>> quite a few right now..
>>>>
>>>> I don't know how much work it would be to make it smarter and attempt
>>>> to parse only the symbols that have been updated. This is really the right
>>>> thing to do for pull requests, but I might need some help parsing the git
>>>> commits in jenkins.
>>>>
>>>> I'm currently playing around in a forked repository (
>>>> https://github.com/reportingsjr/kicad-library). We'll eventually need
>>>> to set up a bot account with permissions on the official repo if we want to
>>>> do this, just a heads up!
>>>>
>>>> Jon
>>>>
>>>> On Tue, Sep 15, 2015 at 5:39 PM, Carl Poirier <carl.poirier.2@xxxxxxxxx
>>>> > wrote:
>>>>
>>>>> The automated message in the pull request would be awesome both for
>>>>> the contributor and the librarian. I mean I would not look at the
>>>>> contribution at all unless it passes or the contributor needs help.
>>>>>
>>>>> I opened a pull request for the contributing part of the website BTW.
>>>>>
>>>>> On Mon, Sep 14, 2015 at 4:52 AM, Ricardo Crudo <
>>>>> ricardo.crudo@xxxxxxxxx> wrote:
>>>>>
>>>>>> Yes, I've thinking about an automation tool, unfortunately these last
>>>>>> weeks I can't find any free time to read  about them. I've did some tests
>>>>>> using Travis a time ago and I don't remember if it has a way to feedback
>>>>>> the user about the issue, I mean something like an automatic message reply
>>>>>> in the pull request. In the other hand I have no idea how Jenkins works.
>>>>>> Does someone know the person who manage the Jenkins?
>>>>>>
>>>>>> Even we have the continuous integration tool running, I think we
>>>>>> could have more librarians, or at least one or two more to manage mainly
>>>>>> the 3d models.
>>>>>>
>>>>>> As soon as possible I'll update the README and CONTRIBUTING files in
>>>>>> the github repo.
>>>>>>
>>>>>> Regards.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Sep 14, 2015 at 12:16 AM, Carl Poirier <
>>>>>> carl.poirier.2@xxxxxxxxx> wrote:
>>>>>>
>>>>>>> Indeed, we definitely need more librarians. I myself don't have much
>>>>>>> time at all for KiCad now. :-(
>>>>>>>
>>>>>>> +1 for the continuous integration tools. Martin, the scripts have
>>>>>>> many many checks working and some more coming. They definitely are the
>>>>>>> piece of software needed for automation.
>>>>>>>
>>>>>>> On Sun, Sep 13, 2015 at 3:42 PM, Martin d'Allens <
>>>>>>> martin.dallens@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> I like the idea of automating part of the process with continuous
>>>>>>>> integration tools. KiCad already has a server:
>>>>>>>> http://ci.kicad-pcb.org/
>>>>>>>>
>>>>>>>> What is the status of these scripts?
>>>>>>>> https://github.com/KiCad/kicad-library-utils
>>>>>>>>
>>>>>>>> Additionnaly, it would be interesting to generate a screenshot of
>>>>>>>> the committed symbols/footprints.
>>>>>>>> I don't know how difficult this would be.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Sep 13, 2015 at 9:08 PM, Samuel Dolt <samuel@xxxxxxx>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Maybe we can use a continuous integration service like travis ci
>>>>>>>>> to automatically run some script on each pull request.
>>>>>>>>>
>>>>>>>>> This will save some time for triage of pull request
>>>>>>>>>
>>>>>>>>> [image:
>>>>>>>>> https://camo.githubusercontent.com/8a5cef3b18bede2e8ef92c1bbf3d1028417a6fec/68747470733a2f2f7261772e6769746875622e636f6d2f6f6c6968656c2f7472617669732d73616d706c652f6d61737465722f646f632f696d616765732f30332d7761726e696e672e6a7067]
>>>>>>>>> ___________________________
>>>>>>>>>
>>>>>>>>> Samuel Dolt
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 13 sept. 2015 à 20:31, nnn <nnn4000@xxxxx> a écrit :
>>>>>>>>>
>>>>>>>>> Asking contributors on github is probably the best way, you can
>>>>>>>>> see who understands KLC and wants to improve libraries. Improving
>>>>>>>>> CONTRIBUTING is good idea, I can see there is not much information there
>>>>>>>>> and it's important to at least add information that: there is KLC that must
>>>>>>>>> be respected, there is script that detects some of issues (not all!), maybe
>>>>>>>>> some information about adding footprints with 3d models. I think that
>>>>>>>>> another big problem is understanding KLC - there is too many pull request
>>>>>>>>> not respecting the rules. Without them librarians work would be easy and
>>>>>>>>> there won't be any problems with growing stack of pull requests. The
>>>>>>>>> solution could be creating illustrated KLC guide with examples (good/bad)
>>>>>>>>> and more verbose explanations if necessary.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Mailing list: https://launchpad.net/~kicad-lib-committers
>>>>>>>>> Post to     : kicad-lib-committers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-lib-committers
>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Mailing list: https://launchpad.net/~kicad-lib-committers
>>>>>>>> Post to     : kicad-lib-committers@xxxxxxxxxxxxxxxxxxx
>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-lib-committers
>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Mailing list: https://launchpad.net/~kicad-lib-committers
>>>>>>> Post to     : kicad-lib-committers@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~kicad-lib-committers
>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~kicad-lib-committers
>>>>> Post to     : kicad-lib-committers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-lib-committers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>
>