launchpad-dev team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxxxxx>]

On August 11, 2009, Guilherme Salgado wrote:
> Hi Francis,
>
> I've had a couple calls with Martin about our breadcrumbs, and one of
> the things we want is to have an extra item for the first traversed
> object on the vhost we're on, in case we're not on the mainsite. e.g.
>
>   bugs.lp.net/bzr
>
> would have
>
>   Bazaar (lp.net/bzr) > Bugs (bugs.lp.net/bzr/+open-bugs)
>
> as breadcrumbs. Note that the link of the new breadcrumb will not point
> to the default (+index) page, so we must be able to customize that for
> any obj/vhost.
>
> Given that, it seemed reasonable to me to change our Hierarchy view to
> sneak an extra item manually and use named adapters (having the vhost as
> the name) so that we can get an IBreadcrumbBuilder for this extra item.

This means that we'll need 5 adapters (bugs, code, answers, translations, 
blueprints) per object type to support. Since this is always for the top level 
objects, it means 25 adapters? (project, project group, distribution, person, 
team). (What about source packages?)

Do we really need a per object customization, isn't a per vhost one enough. 
Wouldn't a +open-bugs be used for all top objects (maybe not person / team).

Might better to have a wider interface (add a getVhostCrumb(name)) method to 
the IBreadcrumbBuilder interface.

>
> How does this sound to you? The small patch attached shows what it'd
> look like.
>


-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.