launchpad-dev team mailing list archive

[Danilo Šegan <danilo@xxxxxxxxxxxxx>]

У чет, 20. 08 2009. у 06:57 +1200, Tim Penhey пише:
> On Thu, 20 Aug 2009 06:51:38 Danilo Šegan wrote:
...
> > and you get a traceback like
> >
> >   http://paste.ubuntu.com/255875/
> >
> > Should we work on a solution for this or should we just work around it
> > by providing adapters for ICanonicalUrlData?

> I have solved this in one of my branches, the one Curtis is reviewing now.

FWIW, that was not enough for me.  Your branch introduced a change in

  canonical.launchpad.webapp.publisher.nearest 

(wrap the code in try...except NoCanonicalUrl: return None), whereas I
had to add something very similar to

  canonical.lazr.canonicalurl.nearest_provides_or_adapted

Before landing this, I want to confirm that this is the right thing to
do.  Should we also have these methods share code as well (they are not
identical, but are very close)?

Cheers,
Danilo