← Back to team overview

launchpad-dev team mailing list archive

[rfc] multiply-targeted code reviews

 

I had the first case today of a branch
<https://code.edge.launchpad.net/~bialix/bzr/win32-paramiko-default/+merge/10563>
that wants to merge into two other branches and it changed the way I
think about merge proposals.  In this case it's a fix that wants to go
both into trunk and our 2.0 release branch.

The model at the moment is that a branch can have multiple proposals,
each to a different target.

However, what I actually want is to have one discussion about the
merits of the change, and then as part of that discussion to say
whether it's reasonable to put into the release branch or not.  In
other words there's one thread, but two conceptual statuses.

Doing this would have some parallels to bugs, which have just one
discussion but multiple bugtasks and statuses for bugs nominated for
backporting into a series.

This would also mesh with the idea that the merge proposal and branch
pages should be more unified.  And if we did make them 1:1 then you
wouldn't need the mp number.

There's some discomfort between the proliferation of individual votes
and the overall status, but if we decide to keep both you could have a
table of status per target.

This would be a nontrivial change but might be an interesting one.

-- 
Martin <http://launchpad.net/~mbp/>



Follow ups