launchpad-dev team mailing list archive

[Henning Eggers <henning.eggers@xxxxxxxxxxxxx>]

Hello on the way to 3.0!

I was surprised to find that Paul's fix[1] to the branch index page does
not include a fix for the line breaks that occur in branch names on that
page[2]. I think that looks very wrong. It can easily be fixed[3] and I
attached a patch for that below.

The fix includes *not* using the registering slot, so maybe there is a
bug in the template that needs fixing. But I don't see any mention of
that on the RolloutBlockers page[4] where I think it belongs.

The bugs index page[5] solves this by placing this information between
the heading and the bread crumbs which is non-conformant to 3.0 UI
standards.

So I believe one of two things must happen before the roll-out:
 * Fix the registering slot to not interfere with the page heading and
update the bug index page to use the slot.
 * Fix both the branch index and the bug index page as I have indicated
by moving the cretor/reporter information under the bread crumbs.

I hope I am not the only one bothered by this.

Henning

[1]https://code.edge.launchpad.net/~rockstar/launchpad/branch-index-redux/+merge/12247
[2]http://people.canonical.com/~henninge/screenshots/branch-index-line-break.png
[3]http://people.canonical.com/~henninge/screenshots/branch-index-fixed.png
[4]https://dev.launchpad.net/CurrentRolloutBlockers
[5]https://bugs.edge.launchpad.net/ubuntu/+bug/1


=== modified file 'lib/lp/code/templates/branch-index.pt'
--- lib/lp/code/templates/branch-index.pt	2009-09-22 17:01:00 +0000
+++ lib/lp/code/templates/branch-index.pt	2009-09-23 10:32:02 +0000
@@ -47,18 +47,15 @@

 </metal:side>

-<tal:registering metal:fill-slot="registering">
+<div metal:fill-slot="main">
+  <div class="top-portlet">
   Created by
     <tal:registrant replace="structure context/registrant/fmt:link" />
   on
     <tal:created-on replace="structure context/date_created/fmt:date" />
   and last modified on
     <tal:last-modified replace="structure
context/date_last_modified/fmt:date" />
-</tal:registering>
-
-
-<div metal:fill-slot="main">
-
+  </div>
   <div class="yui-g first">
     <tal:branch-errors tal:replace="structure context/@@+messages" />
   </div>


-- 
canonical-launchpad mailing list
canonical-launchpad@xxxxxxxxxxxxxxxxxxx
https://lists.ubuntu.com/mailman/listinfo/canonical-launchpad