← Back to team overview

launchpad-dev team mailing list archive

Re: [Branch ~launchpad-pqm/launchpad/devel] Rev 9629: [r=henninge][ui=none][bug=440445] Allow translations branch scanner

 

Bjorn Tillenius wrote:

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2009-10-01 11:42:04 +0000
+++ database/schema/security.cfg	2009-10-02 09:27:02 +0000
@@ -1332,7 +1332,10 @@
 [translationsbranchscanner]
 type=user
 groups=branchscanner
+public.language                         = SELECT
 public.translationrelicensingagreement  = SELECT
+public.translationgroup                 = SELECT
+public.translator                       = SELECT
Where are the tests for this change?
Hi Bjorn, sorry for the late reply; currently sprinting.  What we _want_ 
to do about this is remove the check that requires these privileges in 
the first place.  It's done purely for the initialization of a field 
that has no real use (or if we ever make real use of it, shouldn't be 
initialized in quite this way anyway).
For now, the quick fix is to allow the check to happen.  It happens a 
bit too far down in old code, making it hard to test.  Not impossible, 
but effort + maintenance_cost + test_overhead < regression_cost.

Jeroen



References