← Back to team overview

launchpad-dev team mailing list archive

ec2 land : now even shinier

 

Jono's new 'ec2 land' command makes it really easy to run the test suite on ec2 and have it land your branch. I extended it to be even easier by making the merge proposal URL optional. If exactly one exists for your branch in Launchpad it will be found. If there are more than one you'll still need to specify it on the command line.

Now you can test and submit your branch to PQM by just doing the following:

% my-branch> ec2 land

Things to note:

1) The merge proposal must be reviewed and in the 'Approved' state. Use --force if it is reviewed but not put in 'Approved'.

2) The merge proposal must have a commit message set. If it doesn't you can use '--commit-text' to set it. When using either approach the message should omit the reviewer data ("[r=edwin][ui=none]") as it will be filled in by the script.

3) Having proper review types in the merge proposal is necessary. "code", "ui" , "db", and "release-critical" are recognized and can be used in combination. A mentored reviews "ui*" is also recognized. A review with no review type is treated as a code review.

4) You can see what would be run using the --dry-run option.

--Brad