launchpad-dev team mailing list archive

[Muharem Hrnjadovic <muharem@xxxxxxxxxx>]

Michael Hudson wrote:
> Muharem Hrnjadovic wrote:
>> Michael Hudson wrote:
[..]
>>> For the job of building a recipe into a source package we'll have a
>>> BuildSourcePackageFromRecipeJob table.  I foresee this table looking like:
>>>
>>> BuildSourcePackageFromRecipeJob
>>>  - job
>>>  - recipe
>>>  - archive?
>> Storing the archive here is a good idea IMHO. The question in my mind
>> is: should this really be "BuildPackageFromRecipeJob" i.e. should it span
>> both stages, the generation of the souce package and the subsequent
>> "upload" and build from source package to a binary (.deb file)?
>>
>> In that case we'd probably want a `Build` foreign key as well. It
>> would also give us a more holistic view of the job. Whether that's
>> desirable or cumbersome remains to be seen :)
> 
> Hm.  I was thinking that it would only build the source package, and
> then the source package would get built by something like the existing
> mechanism.  It doesn't have to be done this way, I guess, but it seems
> sanest and easiest to me.
On a second thought I agree.

>> [..]
>>
>>>> The model code should implement the interface ISoyuzJob (although this is a 
>>>> terrible name, it will be changed) which is declared in 
>>>> lib/lp/soyuz/interfaces/soyuzjob.py.
>>> This file doesn't seem to exist?
>> We renamed the interface and moved the files around, please see:
>>
>> lib/lp/buildmaster/model/buildfarmjob.py
>> lib/lp/buildmaster/interfaces/buildfarmjob.py
> 
> Ah.  That all looks OK (apart from BuildFarmJobType probably having too
> many values; not a deep thing).
> 
> This is tangent, but how will scoring work?  I'm guessing the value
> returned by IBuildFarmJob['score'] is stashed in the BuildQueue and then
> it's the value in the BuildQueue that's examined by findBuildCandidates?

Yep.

[..]

Best regards

-- 
Muharem Hrnjadovic <muharem@xxxxxxxxxx>
Public key id   : B2BBFCFC
Key fingerprint : A5A3 CC67 2B87 D641 103F  5602 219F 6B60 B2BB FCFC

Attachment: signature.asc
Description: OpenPGP digital signature