launchpad-dev team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

On Wed, 2009-11-25 at 12:45 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I just got a bunch of strange test failures because there had been
> sampledata changes, and I didn't run "make schema".  They were Soyuz
> test failures, so I asked Julian about it, and he got Muharem involved.
>  So there was a cost in terms of wasted time.
> 
> I don't like to run make schema more than I have to, because it's slow
> and it clears any local changes I've made.  And I only *know* I have to
> run it if there have been schema changes.
> 
> Would it make sense to have a policy of landing sampledata updates in
> db-devel instead?  That's where I'd expect to find database changes, and
> schema updates might have forced me to run "make schema" anyway.

Sampledata cannot be landed in devel, only db-devel.

> Alternatively, automated detection of stale sampledata would have caught
> the issue early.

The intent of the lint it to make sure anyone that lands a schema change
or sampledata change is forced to update all data. Engineers are clearly
circumnavigating the check. Any changes to the sampledata used by the
test runner needs needs careful scrutiny; we made a conscious decision
to not use it any more.


-- 
__Curtis C. Hovey_________
http://launchpad.net/

Attachment: signature.asc
Description: This is a digitally signed message part