launchpad-dev team mailing list archive

[Guilherme Salgado <salgado@xxxxxxxxxxxxx>]

On Wed, 2009-11-25 at 15:32 -0500, Curtis Hovey wrote:
> On Wed, 2009-11-25 at 12:45 -0500, Aaron Bentley wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > I just got a bunch of strange test failures because there had been
> > sampledata changes, and I didn't run "make schema".  They were Soyuz
> > test failures, so I asked Julian about it, and he got Muharem involved.
> >  So there was a cost in terms of wasted time.
> > 
> > I don't like to run make schema more than I have to, because it's slow
> > and it clears any local changes I've made.  And I only *know* I have to
> > run it if there have been schema changes.

I assume these local changes you mention were done in the launchpad_dev
DB, so it'd be a good idea to update the *dev* sampledata ('make
newsampledata') and land that on devel.  That way you'll never have to
do these changes again, and others would benefit from it as well.

Maybe we should encourage people to update the dev sampledata whenever
they add/change something in the launchpad_dev DB. That's cheap, doesn't
cause test failures and is helpful when playing around in
https://launchpad.dev

> > 
> > Would it make sense to have a policy of landing sampledata updates in
> > db-devel instead?  That's where I'd expect to find database changes, and
> > schema updates might have forced me to run "make schema" anyway.
> 
> Sampledata cannot be landed in devel, only db-devel.

We don't have anything that would prevent changes to
database/sampledata/* to land on devel, and I don't know of a policy
that says they should land only on db-devel, so I think it can land on
devel.



-- 
Guilherme Salgado <salgado@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part