launchpad-dev team mailing list archive

[Tim Penhey <tim@xxxxxxxxxx>]

On Thu, 26 Nov 2009 22:05:14 Jonathan Lange wrote:
> On Thu, Nov 26, 2009 at 2:02 AM, Michael Hudson
> >> I think it's mostly fairly uncontroversial.  Some remaining points:
> >>
> >>  - My unique index assumes that the url will be
> >> https://launchpad.net/ubuntu/sourcepackage/+recipe/name or very similar.
> >>  Arguments welcome about whether the owner should be in there :-)
> >
> > I think we should keep the name in the url.
> 
> name, yes. I also think we should have the owner.

I really don't see the point of adding the owner into the traversal.  Having 
the owner as part of the traversal does complicate the traversal somewhat, and 
adds another part that I'm not sure adds a huge amount of value.

How many recipes are we really likely to have per package?  If there were 
going to be a considerable amount then perhaps having the owner name in the 
traversal would help, but for a small number I'm not really sure it adds a 
huge amount.

Although, if we are tying editing to the owner, perhaps we should have it.

As you can see, I'm in two minds.
 
> >>  - The big missing part is where to store the log file and manifest that
> >> are produced by the job's execution.  We could be more like the existing
> >> Soyuz code and have a separate "Build" table that points at these
> >> things, or they could live on BuildSourcePackageFromRecipeJob
> >
> > I think a separate SourcePackageRecipeBuild table mimicing Build (hey,
> > anyone want to rename that BinaryPackageBuild or something? ;-) makes
> > most sense, so I've added that.
> 
> Renaming, eh? We should do more of it.

I'd love to, but we have been told by stub that renaming tables and columns is 
hard now with replication.  I'd love some clarification on this.

Tim