launchpad-dev team mailing list archive

Thread
Date
Re: CSS files now combined

To: Guilherme Salgado <salgado@xxxxxxxxxxxxx>
From: Edwin Grubbs <edwin.grubbs@xxxxxxxxxxxxx>
Date: Tue, 22 Dec 2009 14:48:19 -0600
Cc: Launchpad-dev <launchpad-dev@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <1261396351.5907.11.camel@gorducho>
Sender: edwin@xxxxxxxxxx
On Mon, Dec 21, 2009 at 5:52 AM, Guilherme Salgado
<salgado@xxxxxxxxxxxxx> wrote:
> Hi there,
>
> Last week I landed a branch which combines all our CSS files into a
> single (minified) one.  That means browsers will issue 12 less requests
> on every page load and each of these page loads should be about half a
> second faster.
>
> I've done some manual testing and didn't see any bug reports about
> broken styling, but if you find something wrongly styled, it's possible
> that it was introduced in my branch.
>
> BTW, from now on, when you need to add a new CSS file you'll have to add
> its path (relative to /+icing) to buildout-templates/bin/combine-css.in,
> but there's a comment in base-layout-macros.pt (where you'd normally add
> a new CSS file) explaining where it should be added instead.
>
> --
> Guilherme Salgado <salgado@xxxxxxxxxxxxx>


Does anybody know how to go about fixing this error when running
combine-css? font-weight:bold occurs in a bunch of places, so I can't
tell from the traceback where the error occurs.

WARNING	Property: Unknown Property name. [72:14: word-wrap]
ERROR	Property: Invalid value for "CSS Box Module Level 3/CSS Level
2.1" property: -moz-scrollbars-vertical [93:3: overflow]
WARNING	Property: Unknown Property name. [448:3: filter]
WARNING	Property: Unknown Property name. [449:3: -ms-filter]
WARNING	Property: Unknown Property name. [838:3: -moz-border-radius]
WARNING	Property: Unknown Property name. [839:3: -o-border-radius]
WARNING	Property: Unknown Property name. [840:3: -webkit-border-radius]
ERROR	Property: Invalid value for "CSS Color Module Level 3/CSS Level
2.1" property: grey [922:5: color]
WARNING	Property: Unknown Property name. [1025:5: -moz-border-radius]
WARNING	Property: Unknown Property name. [1026:5: -o-border-radius]
WARNING	Property: Unknown Property name. [1027:5: -webkit-border-radius]
WARNING	Property: Unknown Property name. [1028:5: -khtml-border-radius]
WARNING	Property: Unknown Property name. [1097:3: -moz-border-radius]
WARNING	Property: Unknown Property name. [1098:3: -o-border-radius]
WARNING	Property: Unknown Property name. [1099:3: -webkit-border-radius]
ERROR	Property: Invalid value for "CSS Color Module Level 3/CSS Level
2.1" property: grey [1116:3: color]
WARNING	Property: Unknown Property name. [1325:3: -moz-border-radius]
WARNING	Property: Unknown Property name. [1326:3: -o-border-radius]
WARNING	Property: Unknown Property name. [1327:3: -webkit-border-radius]
ERROR	Property: Invalid value for "CSS Level 2.1" property:
-moz-pre-wrap [1528:3: white-space]
ERROR	Property: Invalid value for "CSS Level 2.1" property:
-o-pre-wrap [1529:3: white-space]
WARNING	Property: Unknown Property name. [1531:3: word-wrap]
WARNING	Property: Unknown Property name. [121:2: font-size_ie_star_hack]
WARNING	Property: Unknown Property name. [14:2: font-size_ie_star_hack]
WARNING	Property: Unknown Property name. [15:2: font_ie_star_hack]
ERROR	Property: Invalid value for "CSS Level 2.1" property: 100% [33:2: font]
WARNING	Property: Unknown Property name. [45:2: font-size_ie_star_hack]
WARNING	Property: Unknown Property name. [39:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [73:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [83:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [100:2: _position]
WARNING	Property: Unknown Property name. [136:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [140:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [146:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [150:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [156:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [160:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [166:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [170:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [176:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [180:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [186:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [190:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [278:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [279:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [285:2: _width]
WARNING	Property: Unknown Property name. [289:2: _width]
WARNING	Property: Unknown Property name. [295:2: _width]
WARNING	Property: Unknown Property name. [301:2: _width]
WARNING	Property: Unknown Property name. [321:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [322:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [327:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [328:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [329:2: _width]
WARNING	Property: Unknown Property name. [338:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [339:2: _margin-right]
WARNING	Property: Unknown Property name. [344:2: margin-right_ie_star_hack]
WARNING	Property: Unknown Property name. [349:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [350:2: _margin-left]
WARNING	Property: Unknown Property name. [354:2: _margin-left]
WARNING	Property: Unknown Property name. [358:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [359:2: _width]
WARNING	Property: Unknown Property name. [362:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [363:2: _width]
WARNING	Property: Unknown Property name. [369:2: _float]
WARNING	Property: Unknown Property name. [371:2: _margin-left]
WARNING	Property: Unknown Property name. [375:2: float_ie_star_hack]
WARNING	Property: Unknown Property name. [376:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [385:2: _margin-left]
WARNING	Property: Unknown Property name. [390:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [395:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [396:2: margin-left_ie_star_hack]
WARNING	Property: Unknown Property name. [403:2: _width]
WARNING	Property: Unknown Property name. [425:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [426:2: _width]
WARNING	Property: Unknown Property name. [432:2: width_ie_star_hack]
WARNING	Property: Unknown Property name. [433:2: _width]
WARNING	Property: Unknown Property name. [480:2: zoom]
WARNING	Property: Unknown Property name. [2:208: filter]
WARNING	Property: Unknown Property name. [2:622: zoom_ie_star_hack]
WARNING	Property: Unknown Property name. [2:669: zoom_ie_star_hack]
WARNING	Property: Unknown Property name. [2:840: zoom_ie_star_hack]
WARNING	Property: Unknown Property name. [2:895: zoom_ie_star_hack]
WARNING	Property: Unknown Property name. [2:958: _zoom]
WARNING	Property: Unknown Property name. [2:1036: _zoom]
WARNING	Property: Unknown Property name. [4:484: line-height_ie_star_hack]
WARNING	Property: Unknown Property name. [4:703: line-height_ie_star_hack]
WARNING	Property: Unknown Property name. [4:1124: _border-bottom]
WARNING	Property: Unknown Property name. [4:1192: _border-bottom]
WARNING	Property: Unknown Property name. [2:37: filter]
ERROR	Property: Invalid value for "CSS Fonts Module Level 3 @font-face
properties/CSS Level 2.1" property: bold [4:623: font-style]
Traceback (most recent call last):
  File "./bin/combine-css", line 31, in <module>
    for content in combine_files(names, icing):
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/lazr_js-0.9.2DEV-py2.5.egg/lazr/js/combo.py",
line 51, in combine_files
    yield combo.filter_file_content(content, full)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/lazr_js-0.9.2DEV-py2.5.egg/lazr/js/build.py",
line 169, in filter_file_content
    css = parser.parseString(stylesheet)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/parse.py",
line 101, in parseString
    encodingOverride=encoding)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstylesheet.py",
line 319, in _setCssTextWithEncodingOverride
    self.cssText = cssText
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstylesheet.py",
line 279, in _setCssText
    default=ruleset)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/util.py",
line 406, in _parse
    expected = p(expected, seq, token, tokenizer)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstylesheet.py",
line 258, in ruleset
    new['namespaces'])
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstylerule.py",
line 144, in _setCssText
    teststyle = CSSStyleDeclaration(styletokens, parentRule=self)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstyledeclaration.py",
line 109, in __init__
    self.cssText = cssText
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstyledeclaration.py",
line 178, in __setattr__
    super(CSSStyleDeclaration, self).__setattr__(n, v)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstyledeclaration.py",
line 314, in _setCssText
    default=unexpected)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/util.py",
line 406, in _parse
    expected = p(expected, seq, token, tokenizer)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/css/cssstyledeclaration.py",
line 305, in unexpected
    ignored,token)
  File "/home/egrubbs/canonical/lp-sourcedeps/eggs/cssutils-0.9.6-py2.5.egg/cssutils/errorhandler.py",
line 98, in __handle
    raise error(msg)
xml.dom.SyntaxErr: CSSStyleDeclaration: Unexpected token, ignoring
upto u'/\n  font-weight: bold;'. [33:48: /]
Follow ups

Re: CSS files now combined
From: Aaron Bentley, 2009-12-22
References

CSS files now combined
From: Guilherme Salgado, 2009-12-21