launchpad-dev team mailing list archive

[Guilherme Salgado <salgado@xxxxxxxxxxxxx>]

Does anybody know why we're seeing all these import policy violations
now?  IIRC we always had a couple of them, but now we have 70!

-------- Forwarded Message --------
From: salgado@xxxxxxxxxxxxx
To: salgado@xxxxxxxxxxxxx
Subject: Test results: SUCCESS
Date: Mon, 4 Jan 2010 19:50:02 +0000 (GMT)

[...]
Total: 25285 tests, 0 failures, 0 errors in 179 minutes 38.950 seconds.

** 70 import policy violations **

There were 70 imports of names not appearing in the __all__.
You should not import IBug from canonical.launchpad.interfaces._schema_circular_imports:
    lp.bugs.browser.bug
    lp.bugs.browser.bugtarget
    lp.bugs.subscribers.bugactivity
    lp.bugs.subscribers.buglastupdated
You should not import IDistribution from canonical.launchpad.interfaces._schema_circular_imports:
    lp.bugs.browser.bugtarget
You should not import IPerson from canonical.launchpad.interfaces._schema_circular_imports:
    lp.bugs.subscribers.bug
    lp.bugs.subscribers.bugactivity
You should not import IBugTracker from lp.bugs.interfaces.bugwatch:
    lp.registry.browser.product
You should not import BranchFormat from lp.code.interfaces.branch:
    lp.codehosting.scanner.bzrsync
You should not import ControlFormat from lp.code.interfaces.branch:
    lp.codehosting.scanner.bzrsync
You should not import RepositoryFormat from lp.code.interfaces.branch:
    lp.codehosting.scanner.bzrsync
You should not import IReclaimBranchSpaceJob from lp.code.interfaces.branchjob:
    lp.code.model.branchjob
You should not import IReclaimBranchSpaceJobSource from lp.code.interfaces.branchjob:
    lp.code.model.branch
    lp.code.model.branchjob
You should not import IRevisionsAddedJob from lp.code.interfaces.branchjob:
    lp.code.model.branchjob
You should not import IUpdatePreviewDiffJobSource from lp.code.interfaces.branchmergeproposal:
    lp.code.model.branchmergeproposaljob
You should not import notify_modified from lp.code.interfaces.branchmergeproposal:
    lp.codehosting.scanner.mergedetection
You should not import BranchSubscriptionNotificationLevel from lp.code.interfaces.branchsubscription:
    lp.codehosting.scanner.email
You should not import CodeImportReviewStatus from lp.code.interfaces.codeimport:
    lp.code.browser.branch
You should not import CodeImportJobState from lp.code.interfaces.codeimportjob:
    lp.code.browser.branch
    lp.code.model.codeimport
You should not import UpdatePreviewDiffJob from lp.code.model.branchmergeproposaljob:
    lp.code.model.branch
You should not import iter_split from lp.code.xmlrpc.codehosting:
    lp.code.model.branchnamespace
    lp.codehosting.inmemory
You should not import schedule_diff_updates from lp.codehosting.scanner.bzrsync:
    lp.codehosting.scanner.branch_scanner
You should not import schedule_translation_upload from lp.codehosting.scanner.bzrsync:
    lp.codehosting.scanner.branch_scanner
You should not import BadUrlScheme from lp.codehosting.vfs.branchfs:
    lp.codehosting.puller.worker
You should not import ISeriesMixin from lp.registry.interfaces.distroseries:
    lp.registry.model.distroseries
You should not import IBugTask from lp.registry.interfaces.milestone:
    lp.registry.browser.mentoringoffer
You should not import IProductRelease from lp.registry.interfaces.milestone:
    lp.bugs.subscribers.bugactivity
You should not import IEmailAddress from lp.registry.interfaces.person:
    lp.registry.browser.person
You should not import IDistributionSourcePackage from lp.registry.interfaces.product:
    lp.registry.browser.distributionsourcepackage
    lp.registry.browser.structuralsubscription
    lp.registry.model.distributionsourcepackage
You should not import IProject from lp.registry.interfaces.product:
    lp.bugs.browser.bugtarget
You should not import BaseRunnableJob from lp.services.job.runner:
    lp.code.model.branchjob
    lp.code.model.branchmergeproposaljob
You should not import extract_bug_numbers from lp.soyuz.browser.sourcepackagerelease:
    lp.registry.browser.distributionsourcepackage
You should not import extract_email_addresses from lp.soyuz.browser.sourcepackagerelease:
    lp.registry.browser.distributionsourcepackage
You should not import linkify_changelog from lp.soyuz.browser.sourcepackagerelease:
    lp.registry.browser.distributionsourcepackage
You should not import PoolFileNotFound from lp.soyuz.scripts.gina.packages:
    lp.soyuz.scripts.gina.handlers
You should not import get_dsc_path from lp.soyuz.scripts.gina.packages:
    lp.soyuz.scripts.gina.handlers
You should not import prioritymap from lp.soyuz.scripts.gina.packages:
    lp.soyuz.scripts.gina.handlers
You should not import urgencymap from lp.soyuz.scripts.gina.packages:
    lp.soyuz.scripts.gina.handlers
You should not import ITranslationImportQueue from lp.translations.model.translationimportqueue:
    lp.registry.model.product
You should not import UTC from pytz:
    lp.translations.scripts.po_import
    lp.translations.scripts.translations_to_branch
You should not import ComponentLookupError from zope.component:
    lp.bugs.browser.bugtask

Successfully ran all tests.


SUBMITTED TO PQM:
[r=abentley][ui=none] Fix remaining templates that were using +style-slimmer.css to use combo.css


-- 
Guilherme Salgado <salgado@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part