← Back to team overview

launchpad-dev team mailing list archive

Re: "make check" is broken

 

On 01/20/2010 07:10 AM, Julian Edwards wrote:
Dear all,

"make check" is currently broken. This is the only way a lot of people have of running the entire test suite. I can run bin/test with no test args but this leaves me feeling uneasy.

{{{
Running tests.
xvfb-run -s '-screen 0 1024x768x24' /home/ed/canonical/lp-branches/missing-
slave-method-bug-509383/bin/test -vv

Tests failed (exit code 1)
make: *** [check] Error 1
}}}

At this point an Xvfb process is left running.

What's going on and how can it be fixed? Telling me to use ec2 is *not* an answer, I want to run tests locally.

Cheers
J

Ok, that is really strange. xvfb is used to run Firefox in a headless environment, and should only by run by buildbot.

Looks like moving the the JS continuous integration onto mainline pulled those builder-specific changes along with them.

One option: check for a DISPLAY environment variable. If it exists, then you are not the buildbot! And you don't need xvfb. If it does exist, then use the xvfb harness. Sound good?

Maris

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References