launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

On Thu, May 20, 2010 at 5:42 PM, Adi Roiban <adi@xxxxxxxxx> wrote:
> Hi,
>
> In LP we have the following code:
>
>    @operation_parameters(
>        pocket=Choice(
>            title=_("Pocket"), required=True,
>            vocabulary=DBEnumeratedType))
>
> and it looks fine to me, but pylint complains about:
>
> lib/lp/registry/interfaces/sourcepackage.py
>    191: [C0322, ISourcePackage.getBranch] Operator not preceded by a
> space
>    required=True,
>    ^
>    vocabulary=DBEnumeratedType))
>
>
> Danilo suggest to raise this issue on the mailinglist and see if we
> should fix lint or our styleguide.
>

No spaces around '=' for keyword arguments ever. World without end.

> What do you think we should do to fix such warning from being raised by
> `make lint` ?
>

Let's drop pylint as part of our "make lint" check.

jml