launchpad-dev team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Hi Adi, et al.

On Thu, 2010-05-20 at 19:42 +0300, Adi Roiban wrote:
...
> lib/lp/registry/interfaces/sourcepackage.py
>     191: [C0322, ISourcePackage.getBranch] Operator not preceded by a
> space
>     required=True,
>     ^
>     vocabulary=DBEnumeratedType))
...
> What do you think we should do to fix such warning from being raised by
> `make lint` ?

I ignore them because they contradict PEP8. The script we use a a hybrid
my my personal lint script written in 2002 and pyflakes Lp script
written in 2005. I personally think pylint is not effective on a large
code base. I do not like waiting for it to process all the changes, and
make bad recommendations.

I replaced my personal lint checker with a new pure python
implementation that checks plain-text, python, doctests, css, and xml.
It uses pyflakes, pep8, and cssutils. It is much faster and more
accurate the the Lp lint script[1]. It also reformat css and doctests to
fix most errors. I could extract my checker from
gedit-developer-plugins.


[1] It also does not complain about undefined identifiers in doctests.

-- 
__Curtis C. Hovey_________
http://launchpad.net/

Attachment: signature.asc
Description: This is a digitally signed message part