launchpad-dev team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

On Mon, 2010-08-09 at 14:27 -0400, Brad Crittenden wrote:
> Last week I attempted to refactor and migrate some classes from
> canonical.launchpad to lp.app.  After getting it mostly done I
> discovered there was a dependency on some of those classes from shipit.
>  Due to the timing in the cycle we decided it was too risky to attempt a
> change to shipit, so the branch was deferred.  This issue has come up
> several times recently.
> 
> Curtis and I propose introducing a new module (perhaps 'lp.shipit') that
> re-exports the symbols shipit depends upon.  The rule going forward
> would be that shipit is not permitted to have any other dependencies.
> If our code moves around, shipit will not have to change, we'll just
> change the definitions in lp.shipit.

I think the module needs to do this:

# XXX sinzui 2010-06-09: shipit requires these glob imports.
from canonical.launchpad.interfaces.lpstorm import (
    IMasterObject, ISlaveStore, IStore)
from canonical.launchpad.interfaces.librarian import ILibraryFileAliasSet
from canonical.launchpad.webapp.interfaces import ILaunchBag, ILaunchpadRoot
from lp.registry.interfaces.person import IPersonSet

We can update this module as we move the canonical parts about.

-- 
__Curtis C. Hovey_________
http://launchpad.net/

Attachment: signature.asc
Description: This is a digitally signed message part