launchpad-dev team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

On Monday 23 August 2010 21:44:01 Guilherme Salgado wrote:
> And that means we don't need to accept binary-only uploads on the
> security policy either, right?

The security policy is redundant, we can remove it entirely.

>   'anything': the name says it all, but it's used just for tests and
> none of our tests do mixed uploads anymore.

There's also 'absolutely-anything'.

> We could replace, then, the 3 attributes with a single enum and simplify
> things a bit, but I'm not sure whether or not we'll want policies
> accepting mixed uploads to accept source-only or binary-only uploads (in
> which case the enum wouldn't make much sense, I think). What do you guys
> think?

I think it can be reduced to a bool!  But a 2-state enum is more future proof.

Cheers
J