launchpad-dev team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

On Aug 24, 2010, at 7:44 PM, Michael Hudson wrote:

> On Wed, 25 Aug 2010 11:27:03 +1200, Robert Collins <robertc@xxxxxxxxxxxxxxxxx> wrote:
>> So for clarity; get_request_timeline would perhaps need a better name,
>> but it would now call get_participation_implementing(..) rather than
>> get_current_browser_request?
> 
> Yes, that's exactly what I meant.
> 
>> Sounds plausible; I think its in reach, so I'll start at the bottom and work up.
> 
> Good.  It didn't seem too bad to me either.  If only Gary was awake to
> run it past him too :-) But it feels correct to me.

I like this plan.

(I really like the idea of putting the webapp.adapter request stuff in request.annotations.)

> 
>> What module should get_participation_implementing live in?
> 
> canonical.launchpad.webapp.interaction perhaps?  I guess we don't want
> to make this depend on the task of figuring out where in the lp package
> all this stuff should really live!

Huge +1

Gary