launchpad-dev team mailing list archive

[Henning Eggers <henning.eggers@xxxxxxxxxxxxx>]

Am 16.09.2010 19:09, schrieb Elliot Murphy:
> On Thu, Sep 16, 2010 at 12:54 PM, Sidnei da Silva
> <sidnei.da.silva@xxxxxxxxxxxxx> wrote:
>> The 'fix' is actually to make sure unicode is used in the places where
>> raw SQL queries are constructed in Launchpad (IIRC). We fixed a
>> handful similar cases in Landscape and we're happily running psycopg
>> 2.2. Thomas Herve might have more details since he landed the branch
>> to fix it.
> 
> This patch to storm might also be needed - if someone confirms that
> Launchpad needs it, I'd be willing to help with getting that patch
> into the version of storm shipping in Maverick.

You are referring to https://bugs.edge.launchpad.net/bugs/585704 ? As my
comment on the LP bug[1] states, I could not verify that it fixes this issue.
I think Sidnei's comment is pointing us the right way here - fixing LP code to
issue unicode in the right places. Until that is done, use an older version of
psycopg2, as we are doing now.

Another alternative might be to add some form of backward compatibility to
either storm of psycpg2 that adds an option to be more permissive about
str/unicode objects (like it was before).

Cheers,
Henning

[1] https://bugs.edge.launchpad.net/launchpad-foundations/+bug/631010