launchpad-dev team mailing list archive

[Graham Binns <graham@xxxxxxxxxxxxx>]

Opinions where I have them...

On 4 October 2010 19:44, Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx> wrote:
>
> authserver.py
> ?

Why not lp.services.authserver?

> launchpad.py
> Most of this belongs to lp.app. I favour moving it there then moving the
> exceptions later.

+1

> launchpadstatistic.py
> lp.app

+1

> librarian.py
> lp.services.librarian

+1

> logintoken.py
> I do not think this is used for login anymore. I think it is a
> ConfirmationToken and that the primary use of it is by lp.registry.
>

Bugs uses it for generating auth tokens for some remote bug trackers,
but I don't see why it shouldn't move to lp.registry (I don't think
all of the code that uses it is in lp.bugs, for that matter).

> looptuner.py
> lp.services.looptunner

+1

> lpstorm.py
> lp.services.storm

+1

> mailbox.py
> lp.services.mail, looks like the migration was not completed
>
> mail.py
> lp.services.mail, looks like the migration was not completed
>

+1 for both.

> message.py
> lp.services.mail, but we use this in a broader sense, maybe
> lp.services.message?

I'm half tempted to say lp.services.comments, but I'm in danger of
cracking open a paint sampler for yon bike shed here.

> oauth.py
> lp.services.oauth
>
> openidconsumer.py
> lp.services.openid
>

+1 for both.

> pathlookup.py
> lp.services.webapp

+1

> schema.py
> ?
>
> searchservice.py
> lp.services.search
>
> temporaryblobstorage.py
> lp.services.librarian

+1 for both

> validation.py
> lp.services.validation, but could be lp.services.field
>

lp.services.validation works for me. Bike shed again.

-- 
Graham Binns | PGP Key: EC66FA7D
http://launchpad.net/~gmb