← Back to team overview

launchpad-dev team mailing list archive

Re: why is LayerProcessController /not/ a mixin?

 

On October 17, 2010, Michael Hudson wrote:
> On Sun, 17 Oct 2010 12:58:26 +1300, Robert Collins 
<robertc@xxxxxxxxxxxxxxxxx> wrote:
> > It has the comment:
> > 
> > class LayerProcessController:
> >     """Controller for starting and stopping subprocesses.
> >     
> >     Layers which need to start and stop a child process appserver or
> > 
> > smtp
> > 
> >     server should call the methods in this class, but should NOT
> > 
> > inherit from
> > 
> >     this class.
> >     """
> > 
> > But its not clear why not? I ask because its directly calling into the
> > db test fixture logic - duplicating DatabaseLayer.
> 
> I don't know, but I'd guess that it's paranoia inspired by the odd way
> layers handle inheritance.
> 

Yes, that's the case. If you use it as a mixin, it gets taken into account for 
the layer running order. 

-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.


References