← Back to team overview

launchpad-dev team mailing list archive

*warning* qa-tagger bad-commit handling is broken

 

I've filed a bug on this, but the deployment report is *incorrectly*
claiming that a revision before 11926 can be deployed. It can't. Don't
try.

I won't be able to dig into this myself, due to being at cassandra
training, but its rather important we don't deploy anything before
11926 - thats Curtis' commit that fixes the key query in
getNewerSourceReleases.

I'm sure Ursula would welcome some assistance if someone wants to dive
in and look at the logic. Whats meant to happen with bad-commit tags
is:
'to deploy a bad-commit tagged revision:
 A) there must be a rollback=REVNO revision
 B) that revision must be included in the deployment
 C) all revisions, including the tagged revision and the rollback
revision must meet the regular qa-ok|qa-untestable rule.
'

Its condition  B that is being violated at the moment.

-Rob



Follow ups