launchpad-dev team mailing list archive

[Robert Collins <robert.collins@xxxxxxxxxxxxx>]

On Fri, Nov 19, 2010 at 4:56 AM, Jonathan Lange <jml@xxxxxxxxxxxxx> wrote:
> On Thu, Nov 18, 2010 at 3:55 PM, Jonathan Lange <jml@xxxxxxxxxxxxx> wrote:
> ...
>>
>>  * The error is in ZopeTestInSubProcess, which I know nothing about.
>>    * Looking at the code, it's just passing in a file descriptor and
>> passing it to subunit
>>
>> In summary:
>>  1. Check up the testtools version hypothesis
>>  2. It's quite possibly a bug in subunit. The fix would be to change
>> readFrom or one of the things it calls.
>>
>
> A work-around would be to not call readFrom from ZopeTestInSubProcess
> but to instead call lineReceived directly, decoding to unicode as you
> do so.

This would be a bad idea; subunit streams are not unicode and you'll
get unicode errors if any attachments are not utf8, and possibly even
if they are due to interactions with chunking: we could trivially
split a multi byte element into two chunks.

Current subunit has this:

    def _lostConnectionInTest(self, state_string):
        error_string = u"lost connection during %stest '%s'" % (
            state_string, self.current_test_description)
        self.client.addError(self._current_test, RemoteError(error_string))
        self.client.stopTest(self._current_test)

in the function in question, which clearly sets a unicode string and
thus should not trigger this error. I haven't checked to see which
release this was fixed in etc, but the solution is going to be
'upgrade to a fixed subunit'.

-Rob