launchpad-dev team mailing list archive

[Graham Binns <graham@xxxxxxxxxxxxx>]

On 6 January 2011 17:57, Gary Poster <gary.poster@xxxxxxxxxxxxx> wrote:
>
> On Jan 6, 2011, at 12:45 PM, Graham Binns wrote:
>
>> I just got this from PQM:
>>
>>> merge bzr+ssh://bazaar.launchpad.net/~gmb/launchpad/subscribe-using-api-bug-697619 bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel
>> Revision: 12170
>> Commit Message: [r=allenap][ui=none][bug=697619]
>> Command was successful.
>>
>> First, I'm entirely unclear about how I managed to submit to PQM
>> without a commit message (other than the flags, of course), though I'm
>> 95% certain it's a PEBKAC rather than a tool problem.
>
> No idea.
>
>> Second, I'm confused as to why PQM didn't reject it (since there's
>> just flags, no commit message). Anyone have any ideas? My guess would
>> be that PQM's regex(es) are deficient, but that's just a guess.
>
> Yes.  I suppose we could add something like \S+.  I didn't really see the point when I reviewed them recently, since that would have been nearly as lenient as no constraint as all.  I don't object, though.
>

Thinking more about it, I wonder if it really matters all that much.
After all, as long as the flags are complete (and PQM is strict about
those, I believe) we have a bug ID, and from there we can get to the
branch and the merge proposal. It's a pain, of course, but then so is
editing the PQM regexes, and I'd be -0 on adding any more complexity
to that that we don't absolutely need.


-- 
Graham Binns | PGP Key: EC66FA7D
http://launchpad.net/~gmb