launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-01-21 05:59 PM, Henning Eggers wrote:
> Robert, Brad and myself reduced the style guide as follows. Please comment.
> 
> https://dev.launchpad.net/PythonStyleGuide?action=diff&rev2=20&rev1=18
> <https://dev.launchpad.net/PythonStyleGuide?action=diff&rev2=20&rev1=18>

I think we should keep "Importing a module should not have side
effects".  One of the libraries used by launchpadlib for storing
passwords does this, as does lp.codehosting, so we can't assume people
will avoid it.

Other than that, I think this looks good.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk09mhYACgkQ0F+nu1YWqI2KHQCggSxfvzBNsFxXGr9QIc2LpLE9
v+wAn0FjqgFEveBaKMqHjhpyEeY+duwU
=SxIg
-----END PGP SIGNATURE-----