launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/25/2011 1:18 PM, Aaron Bentley wrote:
> On 11-01-25 10:57 AM, Graham Binns wrote:
>>  2. If you are the only reviewer or you are the last person to review
>> a branch and you approve it, mark the MP as Approved (this does not
>> happen automatically; maybe it should).
> 
> We're planning on moving to Tarmac, where marking the MP Approved means
> "merge it now", like submitting to PQM.  We actually should get out of
> the habit of marking MPs approved.
> 
> The rest sounds fine, though.
> 
> Aaron

Wasn't that the goal of the Queued state? We ran into this with bzr as
well, wanting a way to differentiate from "doesn't need any more review,
but does need some small tweaks before it is ready to be automatically
merged."

For now, we just went with "ignore tarmac and mark it Approved", I
believe, possibly with a Needs Fixing vote.

John
=:->


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0/KigACgkQJdeBCYSNAANfhwCggTSw05upqd3v26CdZcPZCvsB
QGAAn1ZV/motBug7vt5oiMtfw6IP9oJh
=0vXJ
-----END PGP SIGNATURE-----