← Back to team overview

launchpad-dev team mailing list archive

Re: optional reviews: thumbs up or down?

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-02-11 10:34 AM, Julian Edwards wrote:
> On Friday 11 February 2011 15:16:52 Aaron Bentley wrote:
>> On 11-02-10 10:56 PM, Robert Collins wrote:
>>> So, this has been an experiment for a while; I haven't done an
>>> analysis since late last year, but my sense has been moderate use and
>>> < 10% of landings via it ones where a review /might/ have found
>>> something wrong.
>>
>> -0.  I've avoided them, and in the cases where my reviewer suggested I
>> didn't need a review, I was often able to give examples of things that
>> did deserve review.
> 
> Shouldn't you mention those in the cover letter then?

Ideally, I should, but I don't necessarily think they need mentioning
when I write it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1VYYUACgkQ0F+nu1YWqI2WkgCfQBJksLGwJT4ot2zGyMYYQsCy
JwsAoIMrSu+VkdPKChkMl3gS2hymnVBF
=AIy1
-----END PGP SIGNATURE-----



References