launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

Hello all,

I've been using some spare hacking time to try to clean up some of the
older bits of the Launchpad tree, particularly the 'canonical' package
and the top-level of the tree.

While doing so, I've come across some particularly tantalising
mysteries, and I would appreciate your help in clearing them up.

1. canonical.widgets says it's needed until "shipit is independent".
How can we tell when that has happened?

(I hope to delete canonical.widgets)

2. I don't really understand why canonical.ftests.pgsql (soon to be
lp.testing.pgsql) is needed. Could someone explain? There are some
mysterious comments about "until we've switched to storm"
(test_mockdb) – have we? If so, what opportunities do we have for
clean up? Also, I saw some tests using it directly, surely there's
something they should be using instead?

(I hope to delete canonical.testing.pgsql)

3. canonical.lp is "deprecated", but it doesn't say what it's
deprecated in favour of. Lots of code uses initZopeless from that
module, so I'd guess that it's in favour of
c.database.sqlbase.ZopelessTransactionManager. Bug 484033 doesn't
really add much more information.

(I hope to delete canonical.lp)

4. How long do we need to keep the 'shipit' symlink for? How can we tell?

(I hope to delete the canonical.shipit symlink)

Thanks,
jml