launchpad-dev team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxxxxx>]

Hi Tim,

This looks really great! And the hook up is very palatable! 


One question on the hook-up: any specific reason to do one global event 
containing all the changes, instead of one event per change? Instead of 
subscribing to lp:context:changed event, subscribing to 
lp:context:web_link:changed ? So that call sites don't have to parse the 
changed_fields? Or even more struture, have the cache JSON object be proper 
Attribute-based object on which we could subscribe on the fooChange event 
(http://developer.yahoo.com/yui/3/examples/attribute/attribute-event.html)?

Cheers

-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

On February 22, 2011, Tim Penhey wrote:
> Hi People,
> 
> This is the work that Leonard and I have been messing with for the last
> several days.
> 
> http://people.canonical.com/~tim/js-update.ogv
> 
> And here is the code that hooks it up.
> 
> http://pastebin.ubuntu.com/570891/
> 
> I'm probably going to break it up for review as there were some necessary
> but unrelated changes.  Right now it is almost 2k lines.
> 
> Tim

Attachment: signature.asc
Description: This is a digitally signed message part.