launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...
>> However, the timings I see make me wonder if the same thing is also
>> happening in the XMLRPC *server*. Because with your patch, I thought the
>> xmlrpc times were actually too high, and re-ran it about 10 times to
>> make sure I wasn't seeing things.
>>
>> So doing "Failure.__init__ tb=None" was also having an effect on the
>> xmlrpc side, I just don't see that from the bzr-forker log file. I'll
>> try to update my instrumentation and see if I see anything on the xmlrpc
>> side.
>>
> 
> I'm confused. The XML-RPC server isn't using Deferreds at all.
> 
> jml


It could certainly just be measurement error. The problem is that XMLRPC
calls have very high variance. On my minimally loaded machine
"translatePath()" as an rpc can take anywhere from 16ms to 70+ms, and
"createBranch" can easily go from 40ms to 300ms. So I usually run things
many times in a row, and pick the lowest number to try to filter out the
XMLRPC noise. My log files don't sum up the xmlrpc times and subtract
them from the overall time, which would have helped focus on this.

So I'm not positive why Andrew's changes sped things up, but I do have a
reasonably isolated fix I think we can land in Launchpad, while we try
to fix twisted upstream.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2Rzv4ACgkQJdeBCYSNAAPfhwCgxTPSCvHVW7uybvb3DILRlaeL
qWIAni/unoFzwTO1T81IjPlu8q/NOghF
=rJqW
-----END PGP SIGNATURE-----