launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/14/2011 2:55 AM, Robert Collins wrote:
> Currently we get two (IMO) distinct benefits from running linters:
>  * we find out about functional issues:
>    - repeated definitions
>    - unsafe constructs
>  * We find out about cosmetic issues:
>   - whitespace
>   - indentation
> 
> I think we get great value from the former, and limited if any value
> from the second.
> 
> So, I'd like to propose we do something other projects do: restrict
> lint to reporting on functional issues, and use an idempotent pretty
> printer to reformat our code automatically.
> 
> We would add a post-commit hook in pqm that would reformat the changed
> files using the pretty printer, and we'd no longer need to spend any
> time thinking or worrying about formatting.
> 

As a very small nit-pick, do you mean 'post-commit' or 'pre-commit'? I'm
assuming the latter.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk33X3wACgkQJdeBCYSNAAMxMQCcDflojZffalBjwpvkrK0u75/8
8SsAoNdyXZDBpEHqOd1VZWiH/8Qk1iMM
=64d3
-----END PGP SIGNATURE-----