← Back to team overview

launchpad-dev team mailing list archive

RFC: change from using lint to using a pretty printer

 

Currently we get two (IMO) distinct benefits from running linters:
 * we find out about functional issues:
   - repeated definitions
   - unsafe constructs
 * We find out about cosmetic issues:
  - whitespace
  - indentation

I think we get great value from the former, and limited if any value
from the second.

So, I'd like to propose we do something other projects do: restrict
lint to reporting on functional issues, and use an idempotent pretty
printer to reformat our code automatically.

We would add a post-commit hook in pqm that would reformat the changed
files using the pretty printer, and we'd no longer need to spend any
time thinking or worrying about formatting.

What do you think?

-Rob


Follow ups