launchpad-dev team mailing list archive

[Andrew Bennetts <andrew.bennetts@xxxxxxxxxxxxx>]

John Arbash Meinel wrote:
[…]
> 3) 15ms    hot to Branch.open()...

We just looked into this a little, and found that the majority of the
time in Branch.open() was due to get_stacked_on_url unnecessarily
parsing locations.conf etc when all it needs is the branch.conf.  So
I've just submitted a small patch to improve that (submitted to PQM that
is; it's already been reviewed).  In this situation John reports it
improves this number to 12ms; in some other tests we've done it improved
Branch.open time by more than a factor of 3.

There may well be more low-hanging fruit here.  Another possibility that
springs to mind would be to add a open_locked method so that we don't
need to read the branch.conf more than once.

-Andrew.