← Back to team overview

launchpad-dev team mailing list archive

[Merge] lp:~mbp/launchpad-buildd/890892-derror into lp:launchpad-buildd

 

Martin Pool has proposed merging lp:~mbp/launchpad-buildd/890892-derror into lp:launchpad-buildd.

Requested reviews:
  Launchpad Development mailing list (launchpad-dev)
Related bugs:
  Bug #890892 in Launchpad Auto Build System: "not much information displayed about bzr errors, should use -Derror"
  https://bugs.launchpad.net/launchpad-buildd/+bug/890892

For more details, see:
https://code.launchpad.net/~mbp/launchpad-buildd/890892-derror/+merge/82376

see bug 890892 - make some errors more obvious maybe
-- 
https://code.launchpad.net/~mbp/launchpad-buildd/890892-derror/+merge/82376
Your team Launchpad Development mailing list is requested to review the proposed merge of lp:~mbp/launchpad-buildd/890892-derror into lp:launchpad-buildd.
=== modified file 'buildrecipe'
--- buildrecipe	2011-11-11 12:19:38 +0000
+++ buildrecipe	2011-11-16 10:07:25 +0000
@@ -123,7 +123,9 @@
             'DEBFULLNAME': self.author_name.encode('utf-8'),
             'BZR_EMAIL': bzr_email}
         retcode = call_report_rusage([
-            'bzr', 'dailydeb', '--safe', '--no-build', recipe_path,
+            'bzr',
+            '-Derror',
+            'dailydeb', '--safe', '--no-build', recipe_path,
             self.tree_path, '--manifest', manifest_path,
             '--allow-fallback-to-native', '--append-version',
             '~%s1' % self.distroseries_name], env=env)

=== modified file 'debian/changelog'
--- debian/changelog	2011-11-15 23:56:01 +0000
+++ debian/changelog	2011-11-16 10:07:25 +0000
@@ -1,3 +1,9 @@
+launchpad-buildd (100) hardy; urgency=low
+
+  * Pass -Derror to bzr dailydeb. LP: 890892
+
+ -- Martin Pool <mbp@xxxxxxxxxxxxx>  Wed, 16 Nov 2011 21:05:12 +1100
+
 launchpad-buildd (99) hardy; urgency=low
 
   * launchpad-buildd conflicts with sbuild.