launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-11-29 05:14 PM, Robert Collins wrote:
> e.g. (if lifeless is my object id) 'lifeless is subscribed to
> event tag 'assignee:lifeless'

I was thinking of the narrow case of adding and removing
relationships, so you'd have

notify("$USER requested to review", "$USER requested to review",
"$USER requested to review", ['merge-proposal', 'add-relationship',
'add-reviewer'], ['BranchMergeProposal:25', 'Person:abentley'], [])

I don't really understand how your elaboration would work.  ISTM that
if all reviewers were listed as event tags, it would be hard to work
out whose relationship had changed:

notify("$USER requested to review", "$USER requested to review",
"$USER requested to review", ['merge-proposal', 'add-relationship',
'add-reviewer', 'reviewer:abentley', 'reviewer:lifeless'],
['BranchMergeProposal:25'], [])

btw, I think topics might be better as a mapping, so that we can
distinguish between two objects of the same type with different roles.

notify("proposal created", "proposal created", "proposal
created",['merge-proposal', 'add-relationship', 'add-reviewer'],
{"source_branch": 'Branch:12', "target_branch": 'Branch:10',
"proposal": "BranchMergeProposal:25"}, [])

It seems like it would be nice if we didn't have to specify both
summary and subject.

Also, what are subject_template, body_template and summary_template?
HTML?  MIME?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7WSNUACgkQ0F+nu1YWqI3VHQCeMbXluerBt19ue8r48nwlbBtR
5coAoIS/wj9XwTZJaBrEjcM4AQxlJME6
=CU2W
-----END PGP SIGNATURE-----