← Back to team overview

launchpad-dev team mailing list archive

Combo loader update

 

Hello

Buildbots were successfully updated and the use-convoy branch made it
through no problems. But then qastaging didn't get updated. Turns out it
was a bad idea to set CONVOY_ROOT=/var/tmp/convoy (in the Makefile).
This works fine on local dev machines but needs to be something else on
qastaging and prod.

So to get us going again ASAP, I did a quick fix to the Makefile: the
combo loader targets have been separated out from the normal jsbuild
ones. It is still possible to run the combo loader stuff locally; just
do a "make combobuild" after a normal "make build". And there's also a
clean_combo target that can be run manually. Thanks to William for
reviewing the changes.

We'll get a proper fix in place but putting the convoy root dir into the
Launchpad deployment config. But for now, once rev 14727 gets to
qastaging (real soon now at the time of writing), it will be fixed.

Sorry for the inconvenience.


Follow ups