Thread Previous • Date Previous • Date Next • Thread Next |
On 02/10/2012 09:32 PM, Robert Collins wrote:
Okay, so basically: try to reduce LOC where possible, discuss when you're adding a large chunk of code and apply common sense. I shouldn't have been so nitpickish about specific rules.So there are two aspects here: - we want a trend towards cheaper maintenance; the policy aims to cap things not drive them down. - we want it to be easy to work with So, I'd say if your reviewer is happy, $whatever goes. Keeping changes small, landing things separately - all good. I'd hate to see folk commingle unrelated branches to get the negative LOC thing happening. OTOH, I'd also be disappointed to see someone saying 'hey, 3 months ago I removed 5K LOC, I don't need to try anymore'.
Thanks for clarifying. Cheers, Jelmer
Thread Previous • Date Previous • Date Next • Thread Next |