launchpad-dev team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

On May 15, 2012, at 15:48 , Gavin Panella wrote:

> On 15 May 2012 19:25, Brad Crittenden <bac@xxxxxxxxxxxxx> wrote:
>> Hi Julian,
>> 
>> It appears you are the only one with upload privileges for
>> rabbitfixture on pypi.  Could you either 1) grant me
>> (bradcrittenden) upload rights or 2) upload rabbitfixture 0.3.3 [1]
>> to pypi yourself?

Thanks Julian!

> 
>> 
>> I've created a new release because we're seeing *very* rare startup
>> failures that look like they should be fixed by Martin Pools fix
>> from r 26.
> 
> Brad, can you give any details of the failures? I've had experience of
> weird failures in rabbitfixture and spent a lot of time getting it
> mostly reliable, so even the smallest bit of information might bring
> back some suppressed memories.

Hi Gavin,

I was looking at bug 987444 where we saw rabbit start up problems like:

  File "/var/lib/buildbot/dependencies/eggs/rabbitfixture-0.3.2-py2.6.egg/rabbitfixture/server.py", line 288, in _start
    while time.time() < timeout and self.check_running():
  File "/var/lib/buildbot/dependencies/eggs/rabbitfixture-0.3.2-py2.6.egg/rabbitfixture/server.py", line 260, in check_running
    raise Exception("RabbitMQ server is not running.")
Exception: RabbitMQ server is not running.

The loop to wait while starting in 0.3.2 is calling check_running, which throws the exception we see if the server is not up yet.  This defeats the timeout loop as you will die with an exception on the first pass if it isn't running.

Martin in r26 changed that line to query is_running instead, which simply returns a boolean, allowing the timer loop to proceed.

--Brad

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail