launchpad-dev team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

On Tue, Sep 18, 2012 at 9:44 AM, Curtis Hovey
<curtis.hovey@xxxxxxxxxxxxx> wrote:
> On 09/17/2012 04:35 PM, Deryck Hodge wrote:
>> I'd like to use information_type for a few reasons.
>>
>>
>> **Consistency with other parts of the code**
>>
>> It doesn't make sense to me to have different names for things that
>> are basically the same concept in our code.  it's simpler and more
>> consistent to stick with information_type.  Other devs who come along
>> won't have to get their head around how visibility and
>> information_type are related, even basically the same, yet somehow
>> different.
>
> I am -0 with this. It disagrees with PersonVisibility. Do you want to
> replace PersonVisiblity with InformationType too.
>

I don't want to have to commit Orange to reworking PersonVisibility to
be able to use information_type for Products, though I do agree for
consistency sake it should also change.

Cheers,
deryck


-- 
Deryck Hodge
https://launchpad.net/~deryck
http://www.devurandom.org/