← Back to team overview

launchpad-reviewers team mailing list archive

Fwd: Re: Long method call wrapping - can we standardise on one version?

 

Forwarding again... I fail at using mail clients that aren't mutt.

On 23/07/09 16:58, Barry Warsaw wrote:
> On Jul 23, 2009, at 11:48 AM, Michael Nelson wrote:
> 
>> We should also include the section on wrapping long arguments in
>> function *definitions* [1], which currently seems inconsistent with both
>> of the above examples (but maybe that's intended?):
>>
>>
>> {{{#!python
>>    def function_with_many_args(arg1, arg2, arg3, arg4, arg5,
>>                                spam, eggs, ham, jam, lamb):
>>        """Docstring..."""
>>        # Some code...
>> }}}
>>
>> considering also the case where it's a method (and arg1 is self - ie.
>> must 'self' alway be on the same line as the method name etc.)
>>
> Good question, and I'm a little less decided on this myself.  OT1H it
> would be good to be more consistent with call style, but OTOH, it just
> kind of looks weird to me.

IIRC we settled on this style because it separates the args from the
body of the function. I'm ambivalent about it, however.

-- 
Graham Binns | PGP Key: EC66FA7D


Attachment: signature.asc
Description: PGP signature

Attachment: signature.asc
Description: OpenPGP digital signature