launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve db
The SuggestivePOTemplates table name could be better, but I'll let it pass on humor value.

The UNIQUE needs to be a PRIMARY KEY instead. Otherwise replication will explode, as we can't replicate tables without a defined PRIMARY KEY.

Rather than yet another cronscript for the losas to maintain and monitor, I'd plug this into garbo-daily or garbo-hourly. Yes, it is a little silly having a LoopTuner that will only ever run a single iteration, but there will be no need for another db user, monitor script etc. But this is a DB review so whatever :)

DB patch is patch-2207-

-- 
https://code.launchpad.net/~jtv/launchpad/db-external-suggestions-template-cache/+merge/30694
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/db-external-suggestions-template-cache into lp:launchpad.